Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1743 feat pass scorer list to model evaluation suite #2101

Merged
merged 15 commits into from Oct 26, 2022

Conversation

TheSolY
Copy link
Contributor

@TheSolY TheSolY commented Oct 23, 2022

API unified for all the relevant checks in both tabular and vision.
Passed over the documentation and made sure that no adjustments were required.

@TheSolY TheSolY added the bug label Oct 23, 2022
@TheSolY TheSolY added this to the Hilbert milestone Oct 23, 2022
@TheSolY TheSolY self-assigned this Oct 23, 2022
@TheSolY TheSolY requested review from a team as code owners October 23, 2022 12:59
@TheSolY TheSolY linked an issue Oct 23, 2022 that may be closed by this pull request
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing I think that we should add - an example of using that in the model evaluation quickstart, mention the fact that params can be modified for all checks in Create a Custom Suite guide and last mention that scorers can be determined that way in the metrics guide

@TheSolY TheSolY enabled auto-merge (squash) October 26, 2022 10:18
@TheSolY TheSolY merged commit e275a0f into main Oct 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the 1743-feat-pass-scorer-list-to-model-evaluation-suite branch October 26, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] pass scorer list to model evaluation suite
2 participants