Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing examples notebook validations in CI #221

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Removing examples notebook validations in CI #221

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
347c17b
Removing examples notebook validations in CI
ItayGabbay Dec 6, 2021
9c42e5c
fixing comments
ItayGabbay Dec 6, 2021
569531d
fixing comments
ItayGabbay Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ REQUIREMENTS_LOG := .requirements.log
ANALIZE_PKGS = pylint pydocstyle
TEST_CODE := tests/
TEST_RUNNER_PKGS = pytest pytest-cov pyhamcrest nbval
NOTEBOOK_DIR = ./notebooks/examples ./notebooks/checks
NOTEBOOK_CHECKS = ./notebooks/checks
NOTEBOOK_EXAMPLES = ./notebooks/examples/**/*.ipynb
NOTEBOOK_SANITIZER_FILE= ./notebooks/.nbval-sanitizer

PYLINT_LOG = .pylint.log
Expand Down Expand Up @@ -134,8 +135,9 @@ notebook: $(REQUIREMENTS_LOG) $(TEST_RUNNER)
# as the only time you'll need to run make is in dev mode, we're installing
# deepchecks in development mode
$(PIP) install --no-deps -e .
$(pythonpath) $(TEST_RUNNER) --nbval $(NOTEBOOK_DIR) --sanitize-with $(NOTEBOOK_SANITIZER_FILE)

# Making sure the examples are running, without validating their outputs.
$(JUPYTER) nbconvert --execute $(NOTEBOOK_EXAMPLES) --to notebook --stdout > /dev/null
$(pythonpath) $(TEST_RUNNER) --nbval $(NOTEBOOK_CHECKS) --sanitize-with $(NOTEBOOK_SANITIZER_FILE)
$(TEST_RUNNER):
$(PIP) install $(TEST_RUNNER_PKGS) | tee -a $(REQUIREMENTS_LOG)

Expand Down Expand Up @@ -296,7 +298,7 @@ download:
$(PIP) install $(PROJECT)

jupyter: $(JUPYTER)
$(BIN)/jupyter-notebook $(args) --notebook-dir=$(NOTEBOOK_DIR)
$(BIN)/jupyter-notebook $(args) --notebook-dir=$(NOTEBOOK_CHECKS)

$(JUPYTER):
$(PIP) install jupyter