Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imbalanced drift method #2329

Merged
merged 16 commits into from
Feb 14, 2023

Conversation

nirhutnik
Copy link
Contributor

Added imbalanced drift method (version of Cramer's V)
Added Kolmogorov Smirnov (next PR - make it default)

@nirhutnik nirhutnik requested review from a team as code owners February 13, 2023 15:19
@nirhutnik nirhutnik self-assigned this Feb 13, 2023
@nirhutnik nirhutnik added the feature Feature update or code change to the package label Feb 13, 2023
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments, main one is that we want to switch the default to ks

@noamzbr
Copy link
Collaborator

noamzbr commented Feb 13, 2023

Oh just now read about switch to ks in next PR. No problem. We do need to add explenation about the balanced stuff (and KS) to the drift guide

Co-authored-by: Noam Bressler <noamzbr@gmail.com>
@nirhutnik
Copy link
Contributor Author

Add imbalanced drift method

@nirhutnik nirhutnik added this pull request to the merge queue Feb 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 13, 2023
@nirhutnik nirhutnik added this pull request to the merge queue Feb 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 14, 2023
@nirhutnik nirhutnik added this pull request to the merge queue Feb 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 14, 2023
@ItayGabbay ItayGabbay merged commit 8c22221 into main Feb 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the nir/dee-242-improve-univariate-drift-methods branch February 14, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature update or code change to the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants