Updating Demo Notebooks for How-to-Guides #237
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,759 @@ | |||
| { | |||
There was a problem hiding this comment.
Is that the place to mention the option of "start with predefined suite and slightly modify it to your needs"?
Reply via ReviewNB
There was a problem hiding this comment.
Can we remove & add checks to built-in suites?
If so I think we should add that, but also a part that describes how to do that.
There was a problem hiding this comment.
Ok so I'll add a short description, with a TODO for the example which we'll fill in tomorrow
| @@ -0,0 +1,759 @@ | |||
| { | |||
There was a problem hiding this comment.
I don't think this is something we want to encourage to do... better to just directly refer to the API ref
Reply via ReviewNB
There was a problem hiding this comment.
Yes this was written before we had it. and then I thought it's kind of convenient.
but will delete :)
| @@ -0,0 +1,759 @@ | |||
| { | |||
There was a problem hiding this comment.
I think that it's better to put the imports with the code for copy & paste simplicity.
also I'd add after the definition a print of the suite
Reply via ReviewNB
| @@ -0,0 +1,2112 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,2112 @@ | |||
| { | |||
There was a problem hiding this comment.
all this 4 blocks of code preparations are mostly noise, if possible I'd put them in a single cell, even a collapsed one if possible, as I don't think most users will care to see this.
Reply via ReviewNB
also deleted a few redundant old notebooks