Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature drift reduce output method fix #2428

Merged
merged 1 commit into from Mar 29, 2023
Merged

feature drift reduce output method fix #2428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepchecks/tabular/checks/train_test_validation/feature_drift.py
View file
Open in desktop
Expand Up @@ -282,7 +282,7 @@ def run_logic(self, context: Context) -> CheckResult:
def reduce_output(self, check_result: CheckResult) -> Dict[str, float]:
"""Return an aggregated drift score based on aggregation method defined."""
feature_importance = pd.Series({column: info['Importance'] for column, info in check_result.value.items()})
feature_importance = None if None in feature_importance else feature_importance
feature_importance = None if None in feature_importance.values else feature_importance
values = pd.Series({column: info['Drift score'] for column, info in check_result.value.items()})
return self.feature_reduce(self.aggregation_method, values, feature_importance, 'Drift Score')

Expand Down