Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor text data #2432

Merged
merged 8 commits into from Apr 4, 2023
Merged

refactor text data #2432

merged 8 commits into from Apr 4, 2023

Conversation

Nadav-Barak
Copy link
Collaborator

@Nadav-Barak Nadav-Barak commented Apr 2, 2023 •
edited

Part of effort to robust the nlp base package

Main changes:
Input validation and convert to uniform standard (np arrays)
No outside usage of index (only used internally to support sampling mechanism + display)
Labels and predictions which are not multilabel are converted to str
For token classification - you must supply tokenized text

@Nadav-Barak Nadav-Barak added the feature Feature update or code change to the package label Apr 2, 2023
@Nadav-Barak Nadav-Barak requested a review from a team as a code owner April 2, 2023 11:38
@Nadav-Barak Nadav-Barak self-assigned this Apr 2, 2023
nirhutnik
nirhutnik reviewed Apr 2, 2023
View reviewed changes
Copy link
Contributor

@nirhutnik nirhutnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, not sure what or why you did there with the index, as the previous problems with it were solved... Can you explain why you did it?

deepchecks/nlp/input_validations.py Outdated Show resolved Hide resolved
deepchecks/nlp/text_data.py Outdated Show resolved Hide resolved
deepchecks/nlp/text_data.py Show resolved Hide resolved
deepchecks/nlp/text_data.py Show resolved Hide resolved
deepchecks/nlp/text_data.py Show resolved Hide resolved
deepchecks/nlp/text_data.py Outdated Show resolved Hide resolved
nirhutnik
nirhutnik reviewed Apr 3, 2023
View reviewed changes
deepchecks/nlp/context.py Show resolved Hide resolved
deepchecks/nlp/text_data.py Show resolved Hide resolved
deepchecks/nlp/text_data.py Show resolved Hide resolved
@Nadav-Barak Nadav-Barak merged commit 656d5fc into main Apr 4, 2023
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the NB/Feat/refactor_nlp_base branch April 4, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItayGabbay ItayGabbay ItayGabbay approved these changes

@nirhutnik nirhutnik nirhutnik approved these changes

@shir22 shir22 Awaiting requested review from shir22 shir22 is a code owner

@noamzbr noamzbr Awaiting requested review from noamzbr noamzbr is a code owner

Assignees

@Nadav-Barak Nadav-Barak

Labels
feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nadav-Barak @ItayGabbay @nirhutnik