Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEE-510] nlp integrity checks #2471

Merged
merged 34 commits into from Apr 27, 2023
Merged

[DEE-510] nlp integrity checks #2471

merged 34 commits into from Apr 27, 2023

Conversation

yromanyshyn
Copy link
Contributor

No description provided.

@yromanyshyn yromanyshyn self-assigned this Apr 25, 2023
@yromanyshyn yromanyshyn added feature Feature update or code change to the package nlp Affects deepchecks.nlp package labels Apr 25, 2023
@yromanyshyn yromanyshyn marked this pull request as ready for review April 27, 2023 07:21
noamzbr
noamzbr reviewed Apr 27, 2023
View reviewed changes
deepchecks/nlp/utils/text_utils.py Outdated Show resolved Hide resolved
deepchecks/nlp/utils/text_utils.py Outdated Show resolved Hide resolved
deepchecks/nlp/checks/data_integrity/conflicting_labels.py Outdated Show resolved Hide resolved
deepchecks/nlp/checks/data_integrity/conflicting_labels.py Outdated Show resolved Hide resolved
deepchecks/nlp/checks/data_integrity/conflicting_labels.py Show resolved Hide resolved
deepchecks/nlp/checks/data_integrity/conflicting_labels.py Outdated Show resolved Hide resolved
deepchecks/nlp/checks/data_integrity/text_duplicates.py Outdated Show resolved Hide resolved
deepchecks/nlp/checks/data_integrity/text_duplicates.py Show resolved Hide resolved
deepchecks/nlp/checks/train_test_validation/train_test_sample_mix.py Outdated Show resolved Hide resolved
deepchecks/utils/abstracts/data_duplicates.py Show resolved Hide resolved
yromanyshyn and others added 13 commits April 27, 2023 12:33
@yromanyshyn @noamzbr
Update deepchecks/nlp/checks/data_integrity/conflicting_labels.py
379f4c5 
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
@yromanyshyn
comments fixes
3be5935
@yromanyshyn
Merge branch 'yuriiromanyshyn/dee-510-implement-integrity-checks' of h…
42fe3e9 
…ttps://github.com/deepchecks/deepchecks into yuriiromanyshyn/dee-510-implement-integrity-checks
@yromanyshyn
comments fixes
09b0691
@yromanyshyn @noamzbr
Update deepchecks/nlp/checks/data_integrity/special_characters.py
59fad76 
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
@yromanyshyn @noamzbr
Update deepchecks/nlp/checks/train_test_validation/train_test_sample_…
98e1432 
…mix.py

Co-authored-by: Noam Bressler <noamzbr@gmail.com>
@yromanyshyn @noamzbr
Update deepchecks/nlp/checks/data_integrity/special_characters.py
b9481a9 
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
@yromanyshyn
special chars check fix
346f13a
@yromanyshyn
Merge branch 'yuriiromanyshyn/dee-510-implement-integrity-checks' of h…
378d9b1 
…ttps://github.com/deepchecks/deepchecks into yuriiromanyshyn/dee-510-implement-integrity-checks
@yromanyshyn
added additional condition to the spec chars check
6648edb
@yromanyshyn
renamed "Instances" column to "Sample IDs"; code style fixes;
c06296c
@yromanyshyn
conflicting labels check - small fix
ed86595
@yromanyshyn
Merge branch 'main' into yuriiromanyshyn/dee-510-implement-integrity-…
94b111f 
…checks
noamzbr
noamzbr approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new checks (and their conditions) to the default suites.

deepchecks/nlp/checks/data_integrity/special_characters.py Outdated Show resolved Hide resolved
deepchecks/nlp/checks/data_integrity/special_characters.py Outdated Show resolved Hide resolved
@yromanyshyn
Copy link
Contributor Author

@noamzbr

Add new checks (and their conditions) to the default suites.

added

@noamzbr noamzbr merged commit 019ac48 into main Apr 27, 2023
19 of 22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the yuriiromanyshyn/dee-510-implement-integrity-checks branch April 27, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadav-Barak Nadav-Barak Nadav-Barak left review comments

@noamzbr noamzbr noamzbr approved these changes

@ItayGabbay ItayGabbay Awaiting requested review from ItayGabbay

@shir22 shir22 Awaiting requested review from shir22 shir22 is a code owner

Assignees

@yromanyshyn yromanyshyn

Labels
feature Feature update or code change to the package nlp Affects deepchecks.nlp package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yromanyshyn @noamzbr @Nadav-Barak