Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify weak segments #2485

Merged
merged 6 commits into from May 2, 2023
Merged

simplify weak segments #2485

merged 6 commits into from May 2, 2023

Conversation

Nadav-Barak
Copy link
Collaborator

Mainly - no need to use Dataset and DummyModel in order to run core logic

@Nadav-Barak Nadav-Barak added the feature Feature update or code change to the package label May 1, 2023
@Nadav-Barak Nadav-Barak self-assigned this May 1, 2023
@Nadav-Barak Nadav-Barak requested review from a team as code owners May 1, 2023 15:29
noamzbr
noamzbr reviewed May 1, 2023
View reviewed changes
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deepchecks/utils/abstracts/weak_segment_abstract.py is programatically simpler but human-wise still hard to follow.. Can we add some comments?

deepchecks/utils/abstracts/weak_segment_abstract.py Show resolved Hide resolved
deepchecks/utils/performance/partition.py Show resolved Hide resolved
deepchecks/vision/checks/model_evaluation/weak_segments_performance.py Show resolved Hide resolved
deepchecks/nlp/checks/model_evaluation/weak_segments_performance.py Show resolved Hide resolved
deepchecks/nlp/context.py Show resolved Hide resolved
@Nadav-Barak Nadav-Barak enabled auto-merge (squash) May 2, 2023 14:21
@Nadav-Barak Nadav-Barak merged commit 3bbaa09 into main May 2, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the NB/Feat/annotation_report branch May 2, 2023 14:28
kishore-s-15 pushed a commit to kishore-s-15/deepchecks that referenced this pull request May 7, 2023
@Nadav-Barak @kishore-s-15
simplify weak segments (deepchecks#2485)
ed8c53f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamzbr noamzbr noamzbr approved these changes

Assignees

@Nadav-Barak Nadav-Barak

Labels
feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nadav-Barak @noamzbr