Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CITATION.cff with JMLR Paper #2486

Merged
merged 20 commits into from May 15, 2023
Merged

Update CITATION.cff with JMLR Paper #2486

merged 20 commits into from May 15, 2023

Conversation

shir22
Copy link
Contributor

@shir22 shir22 commented May 2, 2023

No description provided.

Add it as a preferred citation
@shir22 shir22 requested a review from a team as a code owner May 2, 2023 08:45
@shir22 shir22 marked this pull request as draft May 2, 2023 08:47
@noamzbr noamzbr added the documentation modification of the documentation / readme's label May 2, 2023
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And add something about this in README?

shir22 added 13 commits May 2, 2023 12:22
remove tab before authors
remove indent at top
test remove bottom
swap order family name given name
fix Lior's email and return deleted parts
remove preferred citation to see if works
returnned preferred citation without last part
testing it out
another test
test test test
without bottom
revert to original with title
change title and message
indent out authors
copy-paste the last commit that did work (with changing the order of names etc.)
try again to copy-paste previously working version
@shir22 shir22 marked this pull request as ready for review May 15, 2023 15:07
@shir22 shir22 enabled auto-merge (squash) May 15, 2023 15:08
@shir22 shir22 merged commit a2b9fce into main May 15, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the citation-update-article branch May 15, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation modification of the documentation / readme's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants