Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noam/dee 538 better handle download of nltk #2493

Merged
merged 2 commits into from May 4, 2023

Conversation

noamzbr
Copy link
Collaborator

@noamzbr noamzbr commented May 3, 2023

Reference Issues/PRs

NLTK downloads:

  1. download and download test will be quite
  2. If can't download warning will be raised
  3. Alternative paths taken if can't download

Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/deepchecks/deepchecks/blob/main/CONTRIBUTING.rst

@noamzbr noamzbr added the bug label May 3, 2023
@noamzbr noamzbr self-assigned this May 3, 2023
@noamzbr noamzbr requested review from ItayGabbay, shir22 and a team as code owners May 3, 2023 18:27
@noamzbr noamzbr enabled auto-merge (squash) May 3, 2023 20:55
@noamzbr noamzbr merged commit 294ed16 into main May 4, 2023
22 of 23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the noam/dee-538-better-handle-download-of-nltk branch May 4, 2023 06:04
kishore-s-15 pushed a commit to kishore-s-15/deepchecks that referenced this pull request May 7, 2023
* quite download and warnings for nltk stuff

* docs fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants