New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEE-456] nlp dummy model refactoring #2511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yromanyshyn
added
the
refactoring
Making significant changes to structure of code
label
May 10, 2023
noamzbr
reviewed
May 10, 2023
…github.com/deepchecks/deepchecks into yuriiromanyshyn/dee-456-unify-dummy-models
noamzbr
approved these changes
May 10, 2023
Nadav-Barak
reviewed
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To verify, either way predictions and probabilities return as np array?
yeap |
delete-merged-branch
bot
deleted the
yuriiromanyshyn/dee-456-unify-dummy-models
branch
May 11, 2023 06:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nadav-Barak
they do not have much in common, in general,
_predict
and_predict_proba
methods could be separated into some kind of base class, but in this case, we would need to unifynlp.TextData
andtabular.Dataset
APIs, everything else is just a validation logic that is pretty specific IMO. So, I do not see a need in creating some kind of ambiguous and not clear abstractions just to reduce a few lines of codeIn general, I just refactored the nlp dummy model and moved the validation logic into the
input_validation.py
module