Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fixes #2515

Merged
merged 1 commit into from
May 10, 2023
Merged

small fixes #2515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,4 +135,7 @@ benchmarks/results
.user_id

# nlp models
deepchecks/nlp/utils/.nlp-models
deepchecks/nlp/utils/.nlp-models

# embedding files
tests/nlp/utils/embeddings.csv
9 changes: 5 additions & 4 deletions deepchecks/nlp/checks/data_integrity/under_annotated_segments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,9 @@ def _generate_scatter_plot_display(self, encoded_data: pd.DataFrame, is_annotate
encoded_data['virtual_col'] = np.random.uniform(-jitter, jitter, len(encoded_data))

sampled_data = encoded_data.sample(min(MAX_SAMPLES_IN_FIGURE, len(encoded_data)), random_state=42)
annotated_data = sampled_data[is_annotated == 1]
not_annotated_data = sampled_data[is_annotated == 0]
is_annotated_sampled = is_annotated.loc[sampled_data.index] # Get the corresponding boolean series
annotated_data = sampled_data.loc[is_annotated_sampled == 1]
not_annotated_data = sampled_data.loc[is_annotated_sampled == 0]
for _, row in weak_segments.iterrows():
fig = go.Figure()
feature_1, feature_2 = row['Feature1'], row['Feature2']
Expand Down Expand Up @@ -148,7 +149,7 @@ def _generate_scatter_plot_display(self, encoded_data: pd.DataFrame, is_annotate

# Add not annotated scatter plot
fig.add_trace(go.Scatter(x=not_annotated_data[feature_1], y=not_annotated_data[feature_2],
mode='markers', opacity=0.7,
mode='markers', opacity=0.5,
marker=dict(symbol='x', color='red', size=10, line=dict(color='black', width=1)),
hovertemplate=hover_template + 'False',
text=not_annotated_data['text'],
Expand Down Expand Up @@ -238,7 +239,7 @@ class UnderAnnotatedPropertySegments(UnderAnnotatedSegments):
def __init__(self,
properties: Union[Hashable, List[Hashable], None] = None,
ignore_properties: Union[Hashable, List[Hashable], None] = None,
n_top_properties: int = 10,
n_top_properties: int = 15,
segment_minimum_size_ratio: float = 0.05,
n_samples: int = 10_000,
categorical_aggregation_threshold: float = 0.05,
Expand Down
2 changes: 1 addition & 1 deletion deepchecks/nlp/checks/model_evaluation/weak_segments_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ class MetadataSegmentsPerformance(WeakSegmentsAbstractText):
def __init__(self,
columns: Union[Hashable, List[Hashable], None] = None,
ignore_columns: Union[Hashable, List[Hashable], None] = None,
n_top_columns: Optional[int] = 10,
n_top_columns: Optional[int] = 15,
segment_minimum_size_ratio: float = 0.05,
alternative_scorer: Dict[str, Callable] = None,
score_per_sample: Union[np.ndarray, pd.Series, None] = None,
Expand Down