Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nb/bug/weak segments fill na #2560

Merged
merged 5 commits into from May 28, 2023
Merged

Nb/bug/weak segments fill na #2560

merged 5 commits into from May 28, 2023

Conversation

Nadav-Barak
Copy link
Collaborator

Fixed sampling mechanism in text data
Fixed fill na mechanism
Added numerical_metadata attribute (to differentiate from 'other')

https://linear.app/deepchecks/issue/DEE-622/propertymetadata-segment-performance-fails-on-nones

@Nadav-Barak Nadav-Barak requested a review from a team as a code owner May 28, 2023 10:48
@Nadav-Barak Nadav-Barak self-assigned this May 28, 2023
@noamzbr noamzbr added the bug label May 28, 2023
deepchecks/nlp/input_validations.py Show resolved Hide resolved
deepchecks/utils/dataframes.py Show resolved Hide resolved
@Nadav-Barak Nadav-Barak enabled auto-merge (squash) May 28, 2023 12:39
@Nadav-Barak Nadav-Barak merged commit a487b0c into main May 28, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the NB/Bug/weak_segments_fill_na branch May 28, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants