Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the property drift check name and others various fixes #2572

Merged
merged 9 commits into from Jun 1, 2023
Merged

Fix the property drift check name and others various fixes #2572

merged 9 commits into from Jun 1, 2023

Conversation

noamzbr
Copy link
Collaborator

@noamzbr noamzbr commented May 31, 2023

This PR was originally intended to only fix the printed name of the property drift check, but was hijacked to do other things as well:

  1. Avoid an annoying printout by the Fast Tokenizers
  2. Fix a print in the analytics section
  3. Small improvements to the quickstarts.
  4. Small fix to the gitignore

@noamzbr noamzbr added the bug label May 31, 2023
@noamzbr noamzbr requested a review from ItayGabbay as a code owner May 31, 2023 15:58
@noamzbr noamzbr self-assigned this May 31, 2023
@noamzbr noamzbr requested review from shir22 and a team as code owners May 31, 2023 15:58
@noamzbr noamzbr enabled auto-merge (squash) June 1, 2023 06:46
@noamzbr noamzbr disabled auto-merge June 1, 2023 09:20
@noamzbr noamzbr merged commit 96c67c0 into main Jun 1, 2023
21 of 22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the noam/dee-623-decide-on-how-to-call-propertydrift-check branch June 1, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadav-Barak Nadav-Barak Nadav-Barak approved these changes

@ItayGabbay ItayGabbay Awaiting requested review from ItayGabbay

@shir22 shir22 Awaiting requested review from shir22 shir22 is a code owner

Assignees

@noamzbr noamzbr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noamzbr @Nadav-Barak