airbnb fixes and improvements #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadav-Barak
reviewed
Jun 14, 2023
There was a problem hiding this comment.
I dont think this what Bressler meant when he created the issue.
@noamzbr if it is, lets discuss.
noamzbr
reviewed
Jun 14, 2023
There was a problem hiding this comment.
@Nadav-Barak actually airbnb is used in the latter way in the mon quickstarts - first train data and preds are loaded, then production data and pred. It makes sense to use it like that for the quickstarts, though I agree it's not the format used in other datasets. Agree with @JKL98ISR that download times are critical here and so we want to avoid redundant downloads.
@JKL98ISR - did you run this in the monitoring onboarding flow? How did it look like?
|
looks good @noamzbr. tested all possibilities |
noamzbr
approved these changes
Jun 14, 2023
noamzbr
reviewed
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.