Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed model_classes logger warning and made sure tabular only warns once #2604

Merged
merged 4 commits into from Jun 18, 2023
Merged

Changed model_classes logger warning and made sure tabular only warns once #2604

merged 4 commits into from Jun 18, 2023

Conversation

nirhutnik
Copy link
Contributor

@nirhutnik nirhutnik commented Jun 16, 2023 •
edited

  1. Fixed recurring model_classes error (kept sending them when running suite)
  2. Fixed error message in BoostingOverfit (if DummyModel was used, the error message was unclear)

@nirhutnik
Changed model_classes logger warning, and made sure that tabular only…
3e493f8 
… prints that warning once by updating model_classes like in NLP
@nirhutnik nirhutnik added the bug label Jun 16, 2023
@nirhutnik nirhutnik requested a review from a team as a code owner June 16, 2023 20:37
@nirhutnik nirhutnik self-assigned this Jun 16, 2023
@nirhutnik nirhutnik enabled auto-merge (squash) June 18, 2023 07:35
@nirhutnik nirhutnik merged commit b1fa92e into main Jun 18, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix_recurring_model_classes_error branch June 18, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadav-Barak Nadav-Barak Nadav-Barak approved these changes

Assignees

@nirhutnik nirhutnik

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nirhutnik @Nadav-Barak