Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scipy version and broken pillow dependencies in requirements #2620

Merged
merged 9 commits into from Jul 2, 2023

Conversation

harsh-deepchecks
Copy link
Contributor

@harsh-deepchecks harsh-deepchecks commented Jul 2, 2023

Reference Issues/PRs

Fixes #2619
Important fix since it is breaking a lot of tests. In recent scipy's version which is anything greater than 1.10.1 possibly 1.11.X causes the issue to have the index error.
Failing tests here:

The recent version of scipy was released on 29th June.

What does this implement/fix? Explain your changes.

Restricting the version to be less than or equal to 1.10.1 (since I have been testing on this and all things works pretty fine)


Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/deepchecks/deepchecks/blob/main/CONTRIBUTING.rst

Copy link
Collaborator

@Nadav-Barak Nadav-Barak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First lets try a different solution

@harsh-deepchecks
Copy link
Contributor Author

First lets try a different solution

Yes, lets try other possible options and see.

@harsh-deepchecks harsh-deepchecks requested a review from a team as a code owner July 2, 2023 10:08
@harsh-deepchecks harsh-deepchecks changed the title Update scipy version in requirements Update scipy version and broken pillow dependencies in requirements Jul 2, 2023
@harsh-deepchecks harsh-deepchecks merged commit 3ec7ac8 into main Jul 2, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the harsh/scipy-version-fix branch July 2, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix failing tests in tabular
3 participants