Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weak segment - return single segment per feature argument #2645

Merged
merged 3 commits into from Jul 26, 2023
Merged

Weak segment - return single segment per feature argument #2645

merged 3 commits into from Jul 26, 2023

Conversation

Nadav-Barak
Copy link
Collaborator

@Nadav-Barak Nadav-Barak added the feature Feature update or code change to the package label Jul 25, 2023
@Nadav-Barak Nadav-Barak requested a review from a team as a code owner July 25, 2023 14:14
@Nadav-Barak Nadav-Barak self-assigned this Jul 25, 2023
noamzbr
noamzbr reviewed Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we need to see that our relevant examples (plot_ files for the weak segment checks + the tutorials and demos) still look good after this

deepchecks/nlp/checks/data_integrity/under_annotated_segments.py Outdated Show resolved Hide resolved
deepchecks/nlp/checks/model_evaluation/weak_segments_performance.py Show resolved Hide resolved
@Nadav-Barak Nadav-Barak enabled auto-merge (squash) July 26, 2023 08:17
@Nadav-Barak Nadav-Barak merged commit daad127 into main Jul 26, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the NB/Feat/multiple_segment_same_feature branch July 26, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamzbr noamzbr noamzbr approved these changes

@ItayGabbay ItayGabbay Awaiting requested review from ItayGabbay

@shir22 shir22 Awaiting requested review from shir22 shir22 is a code owner

Assignees

@Nadav-Barak Nadav-Barak

Labels
feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nadav-Barak @noamzbr