Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Simple Model Comp condition #2647

Merged
merged 2 commits into from Jul 26, 2023
Merged

Fix the Simple Model Comp condition #2647

merged 2 commits into from Jul 26, 2023

Conversation

noamzbr
Copy link
Collaborator

@noamzbr noamzbr commented Jul 26, 2023 •
edited

handle scorers that are not per class

Reference Issues/PRs

Fixes #2646

@noamzbr noamzbr added the bug label Jul 26, 2023
@noamzbr noamzbr requested a review from a team as a code owner July 26, 2023 05:24
@noamzbr noamzbr self-assigned this Jul 26, 2023
@noamzbr noamzbr merged commit deb16bc into main Jul 26, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the noam/bugfix/fix-cond-when-no-class branch July 26, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadav-Barak Nadav-Barak Nadav-Barak approved these changes

Assignees

@noamzbr noamzbr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error adding custom scorers to SimpleModelComparison check
2 participants
@noamzbr @Nadav-Barak