Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onnx models #2681

Merged
merged 13 commits into from Oct 17, 2023
Merged

onnx models #2681

merged 13 commits into from Oct 17, 2023

Conversation

Nadav-Barak
Copy link
Collaborator

Ability to use onnx gpu optimized models for property calculations

@Nadav-Barak Nadav-Barak added breaking-backwards-compatabillity This Pull Request is breaking backwards API compitabillity feature Feature update or code change to the package labels Oct 16, 2023
@Nadav-Barak Nadav-Barak self-assigned this Oct 16, 2023
@Nadav-Barak Nadav-Barak marked this pull request as ready for review October 16, 2023 12:29
@Nadav-Barak Nadav-Barak requested a review from a team as a code owner October 16, 2023 12:29
noamzbr
noamzbr reviewed Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a big danger that someone will pass device='gpu' in some usage, e.g. how do we call calculate_builtin_properties? Would consider forcing device=None for onnx models

deepchecks/nlp/utils/text_properties.py Show resolved Hide resolved
@Nadav-Barak Nadav-Barak enabled auto-merge (squash) October 16, 2023 16:10
@noamzbr noamzbr disabled auto-merge October 17, 2023 07:22
@noamzbr noamzbr merged commit d1c07ab into main Oct 17, 2023
18 of 22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nadav/llm-803-integrate-the-optimized-models-in-testing-package branch October 17, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamzbr noamzbr noamzbr approved these changes

Assignees

@Nadav-Barak Nadav-Barak

Labels
breaking-backwards-compatabillity This Pull Request is breaking backwards API compitabillity feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nadav-Barak @noamzbr