Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pipeline support for boosting overfit #269

Merged
merged 11 commits into from
Dec 16, 2021
Merged

Added pipeline support for boosting overfit #269

merged 11 commits into from
Dec 16, 2021

Conversation

JKL98ISR
Copy link
Member

No description provided.

Jonthan Liberman and others added 3 commits December 15, 2021 17:01
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JKL98ISR
Copy link
Member Author

we need to add tests for pipeline usage
we also never tested the usage in the features before

@JKL98ISR JKL98ISR self-assigned this Dec 15, 2021
matanper
matanper previously approved these changes Dec 15, 2021
@ItayGabbay
Copy link
Member

Yup, I agree. This can't be merged without unit tests of the pipeline usecase.

@JKL98ISR JKL98ISR merged commit c055096 into main Dec 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the MLC-366 branch December 16, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants