Update label docs and add validation #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shir22
requested changes
Dec 16, 2021
deepchecks/base/dataset.py
Outdated
| if label_name is None: | ||
| label_name = 'target' | ||
| if label_name in self._data.columns: | ||
| raise DeepchecksValueError(f'Data have column with name "{label_name}", use label_name parameter' |
There was a problem hiding this comment.
Why is this validation nested inside the if label_name is None?
There was a problem hiding this comment.
To write another message to the user based on he if passed label_name or not (if he didn't pass label_name but there is still a clash with the default name, target)
shir22
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.