small documentation improvements #276
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…into doc-test-v2
| sys.path.insert(0, str(PROJECT_DIR.absolute())) | ||
|
|
||
|
|
||
| import deepchecks.version |
There was a problem hiding this comment.
I can't import this locally, can you remove it from here, or add it to the package?
There was a problem hiding this comment.
do you mean that you get ImportError when trying to import deepchecks.version?
| <<<<<<< HEAD | ||
| python = $(shell echo ${ext_py} | rev | cut -d '/' -f 1 | rev) | ||
| TESTDIR = $(shell realpath tests) | ||
| ENV = $(shell realpath venv) |
There was a problem hiding this comment.
this command doesn't work locally on my machine
There was a problem hiding this comment.
it's a requirement to update requirements, I don't have it installed by default....
There was a problem hiding this comment.
do you use windows? (I pushed fix for this)
There was a problem hiding this comment.
weird/ Did I understand you right that there is no realpath cmd in mac env?
There was a problem hiding this comment.
if so, I think this cmd will install it - brew install coreutils
|
right now we have duplicate notebooks, is there a way to reference them from outside the source directory? or should we move them to the source and keep them update and tested there? |
It looks like it is not possible to reference documents outside of the source dir in the rst/ at least I was not able to achieve this Think we need to move notebooks to the docs/source folder |
@ItayGabbay any thoughts regarding that? |
|
I have a task on this. Just waiting for the PR in order to start. |
No description provided.