[MLC-379] fixed suite result display #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shir22
previously requested changes
Dec 22, 2021
Comment on lines
+96
to
+97
| f"The suite is composed of various checks such as: {', '.join(check_names[:3])}, etc..." | ||
| if len(check_names) > 3 |
There was a problem hiding this comment.
see comment bellow about unique names (for both lines)
Co-authored-by: shir22 <33841818+shir22@users.noreply.github.com>
matanper
reviewed
Dec 22, 2021
|
@yromanyshyn added a few changes, please review and than merge |
matanper
approved these changes
Dec 23, 2021
@matanper looks good, thanks, but we also need @shir22 approval (merge is blocked without her approval) |
|
oh, actually never mind/ I actually can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.