[MLC-388] added limit on dataset features number for features importance calculation #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
short list of changes:
1)
added
deepchecks.utils.features._NUMBER_OF_FEATURES_LIMIT = 100
to limit features importance calculation only forthe datasets that contain a fewer number of features than the specified limit
2)
added next functions:
+
deepchecks.utils.features.set_number_of_features_limit
+
deepchecks.utils.features.get_number_of_features_limit
to allow user to change
deepchecks.utils.features._NUMBER_OF_FEATURES_LIMIT
after some simple experimentations, it become obvious that the
calculate_feature_importance
execution time is too dependant upon the type of the model (and probably upon of bunch of other variables) so it is not the best idea to leave the user without the possibility to redefine that limit.collected execution time statistics
3)
after the above changes, some modifications were also needed for the next checks
-
WholeDatasetDrift
-
SegmentPerformance
4)
refactored
calculate_feature_importance
function