Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLC-388] added limit on dataset features number for features importance calculation #315

Merged
merged 5 commits into from
Dec 29, 2021

Conversation

yromanyshyn
Copy link
Contributor

short list of changes:

1)

added deepchecks.utils.features._NUMBER_OF_FEATURES_LIMIT = 100 to limit features importance calculation only for
the datasets that contain a fewer number of features than the specified limit

2)

added next functions:
+ deepchecks.utils.features.set_number_of_features_limit
+ deepchecks.utils.features.get_number_of_features_limit
to allow user to change deepchecks.utils.features._NUMBER_OF_FEATURES_LIMIT

after some simple experimentations, it become obvious that the calculate_feature_importance execution time is too dependant upon the type of the model (and probably upon of bunch of other variables) so it is not the best idea to leave the user without the possibility to redefine that limit.

collected execution time statistics

3)

after the above changes, some modifications were also needed for the next checks
- WholeDatasetDrift
- SegmentPerformance

4)

refactored calculate_feature_importance function

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending setting the default to 200

@ItayGabbay ItayGabbay enabled auto-merge (squash) December 29, 2021 08:47
@ItayGabbay ItayGabbay merged commit e9b5036 into main Dec 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the issue-MLC-388 branch December 29, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants