Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch condition errors #449

Merged
merged 2 commits into from Jan 3, 2022
Merged

catch condition errors #449

merged 2 commits into from Jan 3, 2022

Conversation

JKL98ISR
Copy link
Member

@JKL98ISR JKL98ISR commented Jan 3, 2022 •
edited

will look like that instead of failing the whole check:
Screen Shot 2022-01-03 at 15 07 36

@JKL98ISR JKL98ISR self-assigned this Jan 3, 2022
@JKL98ISR JKL98ISR linked an issue Jan 3, 2022 that may be closed by this pull request
Prevent condition from failing check run #435
Closed
matanper
matanper suggested changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@matanper matanper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test of failing condition

@JKL98ISR
Copy link
Member Author

JKL98ISR commented Jan 3, 2022

Add test of failing condition

added

@JKL98ISR JKL98ISR requested a review from matanper January 3, 2022 13:50
@JKL98ISR JKL98ISR merged commit ed5fdf1 into main Jan 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the condition_errors branch January 3, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanper matanper matanper approved these changes

@ItayGabbay ItayGabbay Awaiting requested review from ItayGabbay

Assignees

@JKL98ISR JKL98ISR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent condition from failing check run
2 participants
@JKL98ISR @matanper