Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline model can also no be of type BaseEstimator #468

Merged
merged 2 commits into from Jan 4, 2022
Merged

pipeline model can also no be of type BaseEstimator #468

merged 2 commits into from Jan 4, 2022

Conversation

benisraeldan
Copy link
Contributor

resolves #425

the last step in the pipeline must be an estimator, but doesn't have to inherit from sklearn BaseEstimator

@benisraeldan benisraeldan self-assigned this Jan 4, 2022
@matanper
Copy link
Contributor

matanper commented Jan 4, 2022

We have model_type_validation, wonder if we should use it in the function or in the checks

@benisraeldan
Copy link
Contributor Author

We have model_type_validation, wonder if we should use it in the function or in the checks

added get_model_of_pipeline to model_type_validation

@benisraeldan benisraeldan enabled auto-merge (squash) January 4, 2022 14:39
@benisraeldan benisraeldan merged commit f368333 into main Jan 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the dc-425-pipeline-assumptions branch January 4, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanper matanper matanper approved these changes

@ItayGabbay ItayGabbay Awaiting requested review from ItayGabbay

@JKL98ISR JKL98ISR Awaiting requested review from JKL98ISR

@nirhutnik nirhutnik Awaiting requested review from nirhutnik

Assignees

@benisraeldan benisraeldan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Model Identification in sklearn Pipeline should look at the last step
2 participants
@benisraeldan @matanper