Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve display #610

Merged
merged 39 commits into from Jan 17, 2022
Merged

Improve display #610

merged 39 commits into from Jan 17, 2022

Conversation

JKL98ISR
Copy link
Member

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@JKL98ISR JKL98ISR self-assigned this Jan 13, 2022
@JKL98ISR JKL98ISR added the feature Feature update or code change to the package label Jan 13, 2022
@JKL98ISR JKL98ISR linked an issue Jan 13, 2022 that may be closed by this pull request
Implement a to_widgets() function on the suite result #568
Closed
matanper
matanper reviewed Jan 13, 2022
View reviewed changes
deepchecks/base/check.py Show resolved Hide resolved
deepchecks/base/check.py Outdated Show resolved Hide resolved
deepchecks/base/check.py Show resolved Hide resolved
deepchecks/base/check.py Show resolved Hide resolved
deepchecks/base/display_suite.py Show resolved Hide resolved
deepchecks/base/display_suite.py Outdated Show resolved Hide resolved
matanper
matanper reviewed Jan 16, 2022
View reviewed changes
deepchecks/base/display_pandas.py Show resolved Hide resolved
deepchecks/base/display_suite.py Show resolved Hide resolved
deepchecks/base/display_suite.py Outdated Show resolved Hide resolved
ItayGabbay
ItayGabbay approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@ItayGabbay ItayGabbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think the display_check can be simplified. Worth thinking about that - currently this function is complicated and not so maintainable. However approving for now

@JKL98ISR JKL98ISR merged commit 442ad6d into main Jan 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the display_tabs branch January 17, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItayGabbay ItayGabbay ItayGabbay approved these changes

@matanper matanper Awaiting requested review from matanper

Assignees

@JKL98ISR JKL98ISR

Labels
feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a to_widgets() function on the suite result
3 participants
@JKL98ISR @matanper @ItayGabbay