Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-787] added device parameter to the vision checks context #832

Merged
merged 23 commits into from Feb 14, 2022

Conversation

yromanyshyn
Copy link
Contributor

resolves #787

@yromanyshyn yromanyshyn added the feature Feature update or code change to the package label Feb 8, 2022
@yromanyshyn yromanyshyn self-assigned this Feb 8, 2022
@ItayGabbay
Copy link
Member

@yromanyshyn can you add tests?

Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. Need to merge that with the recent refactor in vision base
  2. Did we test that this work on gpu?

@yromanyshyn
Copy link
Contributor Author

@noamzbr

Two things:
Need to merge that with the recent refactor in vision base
Did we test that this work on gpu?

  1. of course, currently I am writing tests for base vision classes and would like to add them to the current PR, in the near time I will push that changes.
  2. I tried to run it on the collab and checks worked/ but that probably is not a sufficient enough test, will think about how to do it better.

@yromanyshyn yromanyshyn merged commit b2f0c20 into main Feb 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue-787 branch February 14, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature update or code change to the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT][CV] Add support for GPU objects
3 participants