Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to drift plot #867

Merged
merged 5 commits into from Feb 15, 2022
Merged

Add title to drift plot #867

merged 5 commits into from Feb 15, 2022

Conversation

noamzbr
Copy link
Collaborator

@noamzbr noamzbr commented Feb 15, 2022

Closes #864

Add a title showing what feature drift is calculated on before the drift bar and dist plot

@noamzbr noamzbr added the feature Feature update or code change to the package label Feb 15, 2022
@noamzbr noamzbr requested a review from shir22 February 15, 2022 12:59
@noamzbr noamzbr self-assigned this Feb 15, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@shir22 shir22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distribution -> value

@noamzbr noamzbr enabled auto-merge (squash) February 15, 2022 13:25
@noamzbr noamzbr enabled auto-merge (squash) February 15, 2022 13:47
@noamzbr noamzbr merged commit c7ccd5b into main Feb 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-title-to-drift-plot branch February 15, 2022 13:54
@noamzbr noamzbr linked an issue Feb 23, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature update or code change to the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Switch order of titles in drift plots [FEAT] move drift title to before score bar
2 participants