Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding label_map to dataset #877

Merged
merged 12 commits into from Feb 20, 2022
Merged

Adding label_map to dataset #877

merged 12 commits into from Feb 20, 2022

Conversation

ItayGabbay
Copy link
Member

Reference Issues/PRs

Closes #871

What does this implement/fix? Explain your changes.

Adding mapping from label_id to label_name

Any other comments?


Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/deepchecks/deepchecks/blob/main/CONTRIBUTING.rst

@ItayGabbay ItayGabbay added the feature Feature update or code change to the package label Feb 16, 2022
@ItayGabbay ItayGabbay self-assigned this Feb 16, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -273,16 +273,16 @@
"name": "Train Dataset",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This display (num per class) can't handle this number of classes. Need to add to it the same logic we have in metrics...


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open a different issue for that

@ItayGabbay ItayGabbay merged commit 148e0df into main Feb 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the class_map branch February 20, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature update or code change to the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT][CV] Add option to convert class_id to class names
5 participants