Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vision model error analysis #964

Merged
merged 36 commits into from Mar 13, 2022
Merged

vision model error analysis #964

merged 36 commits into from Mar 13, 2022

Conversation

benisraeldan
Copy link
Contributor

Reference Issues/PRs

Resolves #915

What does this implement/fix? Explain your changes.

Refactor model error analysis to work both on tabular and vision, and add vision specific logic

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

noamzbr
noamzbr reviewed Mar 6, 2022
View reviewed changes
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unnecessary changes in the class_performance notebok.

Other then that - mainly organizing the code is needed

deepchecks/vision/checks/performance/model_error_analysis.py Outdated Show resolved Hide resolved
deepchecks/vision/checks/performance/model_error_analysis.py Outdated Show resolved Hide resolved
@benisraeldan
Copy link
Contributor Author

Color are inverted, because higher score is worse than lower score in these cases, also there seem to be an error in the calculation of binary cross entropy

@benisraeldan benisraeldan marked this pull request as ready for review March 7, 2022 10:58
@benisraeldan benisraeldan self-assigned this Mar 8, 2022
@benisraeldan benisraeldan added the feature Feature update or code change to the package label Mar 8, 2022
matanper
matanper reviewed Mar 8, 2022
View reviewed changes
deepchecks/utils/metrics.py Outdated Show resolved Hide resolved
deepchecks/utils/performance/error_model.py Show resolved Hide resolved
deepchecks/utils/single_sample_metrics.py Outdated Show resolved Hide resolved
deepchecks/vision/checks/performance/model_error_analysis.py Outdated Show resolved Hide resolved
deepchecks/vision/metrics_utils/iou_utils.py Show resolved Hide resolved
deepchecks/vision/metrics_utils/iou_utils.py Outdated Show resolved Hide resolved
@benisraeldan benisraeldan enabled auto-merge (squash) March 13, 2022 13:13
@benisraeldan benisraeldan merged commit 6fafb35 into main Mar 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the dc-915-vision-model-error-analysis branch March 13, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamzbr noamzbr noamzbr left review comments

@ItayGabbay ItayGabbay ItayGabbay left review comments

@matanper matanper matanper approved these changes

Assignees

@benisraeldan benisraeldan

Labels
feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT][CV] Vision model error analysis
4 participants
@benisraeldan @matanper @noamzbr @ItayGabbay