Confusion matrix bug #983
Merged
Confusion matrix bug #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
noamzbr
approved these changes
Mar 9, 2022
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we rely in the confusion matrix on detections to have consecutive classes.
If we will have 100 classes but not consecutive (for example we have class id 110) we will try to access the matrix at index 110 and will get out of bounds exception.
Another problem is the model might return classes which we haven't seen before. For example our dataset have class ids between 0-100, and the model can return suddenly 120. For now, I just put all the "unseen" under the same bucket, since this requires a much larger refactor in order to fix.