-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensorflow independent environment #2567
Conversation
In deepchem/deepchem/trans/transformers.py Line 1540 in eab6ee6
deepchem/deepchem/trans/transformers.py Line 1977 in eab6ee6
Can we move these features into a seperate file called
|
It looks to me like they're just using TensorFlow for a bunch of standard math operations that could just as easily be done with Numpy. I suggest we convert them. I notice though that there don't seem to be any tests for ANITransformer, and also that it's written in TensorFlow 1.x style. I wouldn't be surprised if it doesn't actually work, but no one noticed due to the lack of tests and because no one is using it. |
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
==========================================
+ Coverage 84.85% 85.17% +0.31%
==========================================
Files 314 314
Lines 28084 27972 -112
==========================================
- Hits 23831 23824 -7
+ Misses 4253 4148 -105
Continue to review full report at Codecov.
|
So should i put ANITransformer in a separate file like mentioned above or remove it completely? |
@VIGNESHinZONE I think for ANITransformer, it's been known to be broken for some time so let's just comment it out. We'll have to note it in #2553. |
I think this PR will also need to be rebased since some merge conflicts have crept it |
@rbharath I have made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think this is ready to merge in. I'm seeing only 1 test failure on a test unrelated to this PR.
@peastman Do you have any remaining review comments?
Looks good to me. |
Fix #2561
try
&catch
based on a few sub-packages in deepchem likemetalearning
,keras_models
,rl
because these sub-packages aretensorflow
dependent.trans
subpackage because theTensorFlow
dependency was local.cc: @peastman @rbharath
#2563 requires a tensorflow free environment for smoothly creating a
deepchem-[torch]
environment.