Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gpu installation #2806

Merged
merged 2 commits into from Jan 12, 2022
Merged

fix gpu installation #2806

merged 2 commits into from Jan 12, 2022

Conversation

Chahalprincy
Copy link
Contributor

Fix GPU installation. #2793 this changed the installation process and there were few updates needed for GPU installation.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.22.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@rbharath
Copy link
Member

rbharath commented Jan 7, 2022

Thanks for the contribution!

@arunppsg Could you do a quick review pass when you get a chance?

@arunppsg
Copy link
Contributor

arunppsg commented Jan 8, 2022

LGTM!

Hey @Chahalprincy, I have also forgotten to add tensorflow and jax gpu installation there (they are only there for the CPU right now) earlier. Will you be interested in adding them? Thanks!

@Chahalprincy
Copy link
Contributor Author

Thanks, @arunppsg. I've added the Jax GPU dependencies, I didn't see any TensorFlow GPU dependencies in the previous version also. So, I have not added those in. Please let me know if you need any changes.

@arunppsg
Copy link
Contributor

The failures seems unrelated to this PR, will merge this in. Thanks for your contribution!

@arunppsg arunppsg merged commit 1546252 into deepchem:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants