-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake graph data generator #2865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments below about the docs
I have not added the class to The failures seems to be the regular flaky ones. |
0ffa74c
to
3263f00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
5901c11
to
6e04da3
Compare
5830867
to
d56a8eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to merge once CI is passing
In this PR, I have added a
FakeGraphDataset
generator which can be used for generating random graphs. Main motivation to have this is to generating random graphs with different properties for testing graph models.Pytorch-geometric has a
FakeDataset
class but this has two improvements over it:But this should be fixed in PyG 2.0.4 and by then, we can depreciate it.