Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake graph data generator #2865

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Fake graph data generator #2865

merged 3 commits into from
Feb 25, 2022

Conversation

arunppsg
Copy link
Contributor

In this PR, I have added a FakeGraphDataset generator which can be used for generating random graphs. Main motivation to have this is to generating random graphs with different properties for testing graph models.

Pytorch-geometric has a FakeDataset class but this has two improvements over it:

  • Different graph classes have different node features
  • Support kwargs (can be used to have global graph-level features)
    But this should be fixed in PyG 2.0.4 and by then, we can depreciate it.

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments below about the docs

deepchem/utils/fake_data_generator.py Show resolved Hide resolved
deepchem/utils/fake_data_generator.py Outdated Show resolved Hide resolved
@arunppsg
Copy link
Contributor Author

arunppsg commented Feb 19, 2022

I have not added the class to deepchem/docs since these will be depreciated once next version of PyG is released.

The failures seems to be the regular flaky ones.

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

deepchem/utils/fake_data_generator.py Outdated Show resolved Hide resolved
deepchem/utils/fake_data_generator.py Outdated Show resolved Hide resolved
deepchem/utils/fake_data_generator.py Outdated Show resolved Hide resolved
deepchem/utils/fake_data_generator.py Show resolved Hide resolved
@arunppsg arunppsg force-pushed the fakedata branch 2 times, most recently from 5901c11 to 6e04da3 Compare February 24, 2022 14:24
@arunppsg arunppsg force-pushed the fakedata branch 2 times, most recently from 5830867 to d56a8eb Compare February 25, 2022 02:44
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge once CI is passing

@arunppsg arunppsg merged commit 76be8ae into deepchem:master Feb 25, 2022
@arunppsg arunppsg deleted the fakedata branch June 30, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants