Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP-008 style corrections for electron sampler #2987

Merged
merged 2 commits into from
Jul 10, 2022

Conversation

shaipranesh2
Copy link
Contributor

Pull Request Template

Description

A few minor changes to the module's name according to the PEP-008 style changes

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@shaipranesh2 shaipranesh2 changed the title PEP-008 style corrections for electrom sampler PEP-008 style corrections for electron sampler Jul 8, 2022
Copy link
Contributor

@peastman peastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@peastman peastman merged commit ad2d874 into deepchem:master Jul 10, 2022
shaipranesh2 added a commit to shaipranesh2/deepchem that referenced this pull request Aug 14, 2022
* PEP-008 style corrections

* doctest changes
shaipranesh2 added a commit to shaipranesh2/deepchem that referenced this pull request Aug 23, 2022
* PEP-008 style corrections

* doctest changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants