Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of NeighborList from Keras to Torch #3020

Merged
merged 11 commits into from Aug 10, 2022
Merged

Conversation

subzjee
Copy link
Contributor

@subzjee subzjee commented Aug 1, 2022

Pull Request Template

Description

#2930
Ported NeighborList to Torch.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@rbharath
Copy link
Member

rbharath commented Aug 2, 2022

Thanks for the contribution! I took a quick look and it seems reasonable. I've turned on the CI run (github disables for first time contributors), so we can see if there are any test failures we need to look at.

@subzjee
Copy link
Contributor Author

subzjee commented Aug 7, 2022

Some checks are failing but those seem to be unrelated.

@subzjee
Copy link
Contributor Author

subzjee commented Aug 7, 2022

Per the feedback by @shivance on the other PRs, I imported the layer in the module.

@arunppsg
Copy link
Contributor

arunppsg commented Aug 10, 2022

LGTM! Thanks for the contribution.

@arunppsg arunppsg merged commit 6b52a15 into deepchem:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants