Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dataset when the dimension of y is 1 #3163

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Conversation

advikavs
Copy link
Contributor

@advikavs advikavs commented Jan 5, 2023

Description

Fix #3130

Dataset merge does not work when the dimension of y is 1. We fix this by checking the dimension and reshaping accordingly.

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we merged in the 4 space yapf, we may need to do a preliminary PR running yapf on datasets.py before we can merge this PR in.

We also look to have a lot of mypy errors (unrelated to this PR but in general)

@arunppsg
Copy link
Contributor

arunppsg commented Jan 9, 2023

Since we merged in the 4 space yapf, we may need to do a preliminary PR running yapf on datasets.py before we can merge this PR in.

yapf for datasets.py is done in #3166 . Merging this in.

@arunppsg arunppsg merged commit 3c7e757 into deepchem:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset merge when y's dimension is 1
3 participants