Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds in a fundamental deepchem layer multilayer perceptron (MLP). This is a simple fully connected feed forward network.
I named it MLP instead of feedforward, since even though feedforward is a common term for it, it can also mean a general network with no cycles. I did not include dropout for the input layer, as this seems to be the common implementation of dropout. Specifying 0 layers will return the input, 1 layer is a single linear layer, and 2+ layers adds additional linear+dropout layers.
I do have a mypy error on activation_fn:
deepchem/models/layers.py:100: error: Incompatible default for argument "activation_fn" (default has type "None", argument has type "Callable[..., Any]")
I'm not really sure what is the problem there, if someone has any input.
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>
and check no errors (yapf version must be 0.32.0)mypy -p deepchem
and check no errorsflake8 <modified file> --count
and check no errorspython -m doctest <modified file>
and check no errors