Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedforward #3164

Merged
merged 8 commits into from
Jan 10, 2023
Merged

Feedforward #3164

merged 8 commits into from
Jan 10, 2023

Conversation

tonydavis629
Copy link
Collaborator

Pull Request Template

Description

Adds in a fundamental deepchem layer multilayer perceptron (MLP). This is a simple fully connected feed forward network.

I named it MLP instead of feedforward, since even though feedforward is a common term for it, it can also mean a general network with no cycles. I did not include dropout for the input layer, as this seems to be the common implementation of dropout. Specifying 0 layers will return the input, 1 layer is a single linear layer, and 2+ layers adds additional linear+dropout layers.

I do have a mypy error on activation_fn:
deepchem/models/layers.py:100: error: Incompatible default for argument "activation_fn" (default has type "None", argument has type "Callable[..., Any]")

I'm not really sure what is the problem there, if someone has any input.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed offline with @tonydavis629

  • Yapf changes need to be made in a separate PR
  • Rename to MultilayerPerceptron

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval, couple of minor formatting fixes remain. Feel free to merge after fixed (discussed offline)

@tonydavis629
Copy link
Collaborator Author

I actually don't have merge permissions so if @rbharath or @gusty1g you could give me permissions I can merge this in.

@tonydavis629 tonydavis629 merged commit 259f9c2 into deepchem:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants