Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yapf fixes on deepchem/utils part three #3205

Merged
merged 3 commits into from
Jan 29, 2023
Merged

yapf fixes on deepchem/utils part three #3205

merged 3 commits into from
Jan 29, 2023

Conversation

maithili232
Copy link
Contributor

@maithili232 maithili232 commented Jan 26, 2023 •
edited

Pull Request Template

Description

Fix #3159

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

arunppsg
arunppsg requested changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@arunppsg arunppsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some parts, docstrings are not well formatted. Also, the checklist in the pull request template must be filled up.

advikavs
advikavs reviewed Jan 27, 2023
View reviewed changes
deepchem/utils/molecule_feature_utils.py Outdated
A one-hot vector of the number of hydrogens which an atom has.
If `include_unknown_set` is False, the length is `len(allowable_set)`.
If `include_unknown_set` is True, the length is `len(allowable_set) + 1`.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check indent

advikavs
advikavs reviewed Jan 27, 2023
View reviewed changes
deepchem/utils/noncovalent_utils.py
Dictionaries mapping atom indices to number of atoms they interact with.
Separate dictionary is created for each type of pi stacking (parallel and
T-shaped) and each molecule (mol1 and mol2).
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

285-301 needs to be formatted

@arunppsg arunppsg merged commit 0611ac5 into deepchem:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advikavs advikavs advikavs left review comments

@arunppsg arunppsg arunppsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating deepchem to follow 4 spaces for indentation
3 participants
@maithili232 @arunppsg @advikavs