Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yapf fixes on deepchem.feat module #3211

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Conversation

arunppsg
Copy link
Contributor

Pull Request Template

Description

Fix #3159

This PR, along with #3207 completes yapf updates on deepchem.feat module.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
  • I have performed a self-review of my own code

@GreatRSingh
Copy link
Contributor

Which directories of deepchem/feat are being indented in this PR #3211.
Asking so that I can indent the remaining directories in my PR #3207.

@arunppsg
Copy link
Contributor Author

Which directories of deepchem/feat are being indented in this PR #3211. Asking so that I can indent the remaining directories in my PR #3207.

I think most of the yapf fix PRs are landed - I need to check the CI, get them reviewed and merge in. If something is missed out, I will let you know.

@arunppsg arunppsg merged commit 2388d66 into deepchem:master Feb 3, 2023
@arunppsg arunppsg deleted the yapf-feat branch February 3, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating deepchem to follow 4 spaces for indentation
2 participants