Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 errors #3235

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Fix flake8 errors #3235

merged 4 commits into from
Feb 13, 2023

Conversation

brianpzaide
Copy link
Contributor

Pull Request Template

Description

Fix #3182

fixing flake8 error in "deepchem/models dir"

Type of change

Please check the option that is related to your PR.

Checklist

  • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
  • Run mypy -p deepchem and check no errors

@arunppsg
Copy link
Contributor

Hey, there seems to be some failure in the CI. Some are yapf errors. The failure on jax CI occurring as an import error in test_optimizers.py seems to be concerning. Any idea why it might be happening?

@brianpzaide
Copy link
Contributor Author

I do not know why there is an import error.
I ran the test locally(I commented out the actual tests)this is what i did
code
here's the snapshot of the result
test
i did not get any import errors.
i am reading on python import system, namespaces may be if I can find something

@arunppsg
Copy link
Contributor

@brianpzaide I am not sure 66245c7 will fix the issue.

Summary of change: I replaced the usage of TorchModel with dc.data.TorchModel.

The reason why I am hoping this will fix the issue is in deepchem CI tests for jax, we don't install torch dependencies (pytorch and others) in the workflow. When from deepchem.models import TorchModel is at the top, the import will fail because pytorch is not installed.

@brianpzaide
Copy link
Contributor Author

brianpzaide commented Feb 13, 2023

@gusty1g I see, I had not read the github workflows directory earlier, my bad
thanks

@arunppsg arunppsg merged commit 6082ee9 into deepchem:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake8 checks on deepchem/models directory
2 participants