Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tutorial notebooks: Loading model arg split changed to splitter #3274

Closed
wants to merge 2 commits into from

Conversation

yihuajack
Copy link

Pull Request Template

Description

Fix #3273

'split' is deprecated. Use 'splitter' instead.

Also fix the wrong Google Colab link of Advanced_model_training_using_hyperopt.ipynb

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@yihuajack yihuajack changed the title Loading model arg split changed to splitter In tutorial notebooks: Loading model arg split changed to splitter Mar 13, 2023
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Could you split this PR up into multiple PRs? For new developers, I usually recommend not changing more than one tutorial at a time; it becomes too hard to review for us.

@yihuajack
Copy link
Author

How to split one PR into multiple PRs? Sorry I have not done this before

This PR only modifies code

  • the split argument to splitter in the listed 6 notebooks, each notebook only 1 change
  • the Google Colab link of Advanced_model_training_using_hyperopt.ipynb

Some of the notebooks include outputs using old versions of deepchem. To test whether the above modifications change the results, I ran those notebooks to check whether the outputs make the same sense as before. If needed, the debugging information of the outputs like the progress of installing packages can be removed.

@rbharath
Copy link
Member

You can make a fresh PR and copy in a subset of changes. If you have questions, can you come by office hours (9am PST every weekday) https://forum.deepchem.io/t/announcing-the-deepchem-office-hours/293

This reverts commit 732d60b and keep only fix advanced model training with hyperopt
@yihuajack
Copy link
Author

OK, I'll make a fresh PR and close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split in tutorials deprecated, use splitter instead
2 participants