Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed embedding output type arg in grover #3300

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

arunppsg
Copy link
Contributor

Pull Request Template

Description

I am removing the embedding_output_type argument from grover as it is not needed and used.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me, but let's briefly discuss offline what the original goal for embedding_output_type was and why we no longer need it before we merge

@arunppsg
Copy link
Contributor Author

Changes look fine to me, but let's briefly discuss offline what the original goal for embedding_output_type was and why we no longer need it before we merge

They were additional options present in the grover codebase but not used for experiments or the study. We might not need it because their use case is undocumented in the paper.

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge in once CI is clear. You may need to give it a bump to rerun CI

@arunppsg arunppsg merged commit be50ae0 into deepchem:master Mar 27, 2023
@arunppsg arunppsg deleted the grover-remove-emb branch March 27, 2023 09:16
@rbharath rbharath mentioned this pull request Mar 29, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants