Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pull request 3271 - wrapper to use hugging face algorithms for vocabulary building #3314

Merged
merged 7 commits into from
Mar 29, 2023

Conversation

arunppsg
Copy link
Contributor

@arunppsg arunppsg commented Mar 29, 2023

Pull Request Template

Description

I would like to revert the pull request #3271 because for some reason, the unit test CI is failing randomly with a message no space left in the device during installation of dependency. For example, this is a unit test CI where the tests ran and this is a case where it failed.

Since it is causing a failure in installation, the new changes will also block other pull requests. Hence, reverting it will fix the issue temporarily by unblocking other pull requests.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@arunppsg arunppsg changed the title Revert 3271 hf vocab Revert pull request 3271 - wrapper to use hugging face algorithms for vocabulary building Mar 29, 2023
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge in once ready

@arunppsg arunppsg merged commit 213abe3 into master Mar 29, 2023
@arunppsg arunppsg deleted the revert-3271-hf-vocab branch March 29, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants