-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InfographStar Multitask Classification and Regression #3318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good to be merged in once CI is clear
@@ -7,7 +7,7 @@ | |||
|
|||
@pytest.mark.torch | |||
def get_classification_dataset(): | |||
np.random.seed(123) | |||
# np.random.seed(123) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this if it's not needed
@rbharath So the CI is crashing I think because of the high memory of the tests. They pass on my machine. I have lowered the memory requirements of the tests so they don't crash, but I promise this PR won't blow up the CI if you need to merge it tonight before the CI finishes. Edit: It's clear to merge |
Pull Request Template
Description
This PR adds multitask classification mode to InfoGraphStar. This is accomplished by modifying the model nn.module to format its forward pass output dimensions appropriately to the mode.
Type of change
Please check the option that is related to your PR.
Checklist
Checklist
yapf -i <modified file>
and check no errors (yapf version must be 0.32.0)mypy -p deepchem
and check no errorsflake8 <modified file> --count
and check no errorspython -m doctest <modified file>
and check no errors