Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfographStar Multitask Classification and Regression #3318

Merged
merged 17 commits into from
Apr 2, 2023

Conversation

tonydavis629
Copy link
Collaborator

Pull Request Template

Description

This PR adds multitask classification mode to InfoGraphStar. This is accomplished by modifying the model nn.module to format its forward pass output dimensions appropriately to the mode.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

Checklist

  • My code follows the style guidelines of this project
  • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
  • Run mypy -p deepchem and check no errors
  • Run flake8 <modified file> --count and check no errors
  • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@tonydavis629 tonydavis629 changed the title InfographStar Classification InfographStar Multitask Classification amd Regressopm Mar 30, 2023
@tonydavis629 tonydavis629 changed the title InfographStar Multitask Classification amd Regressopm InfographStar Multitask Classification and Regression Mar 30, 2023
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good to be merged in once CI is clear

@@ -7,7 +7,7 @@

@pytest.mark.torch
def get_classification_dataset():
np.random.seed(123)
# np.random.seed(123)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this if it's not needed

@tonydavis629
Copy link
Collaborator Author

tonydavis629 commented Mar 31, 2023

@rbharath So the CI is crashing I think because of the high memory of the tests. They pass on my machine. I have lowered the memory requirements of the tests so they don't crash, but I promise this PR won't blow up the CI if you need to merge it tonight before the CI finishes.

Edit: It's clear to merge

@rbharath rbharath merged commit 96050f8 into deepchem:master Apr 2, 2023
@tonydavis629 tonydavis629 deleted the infograph_csfy branch April 3, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants