-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding spin and charge properties to dft data #3355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documenting offline discussion, there is a failure in the DQC tests that we need to check out as well
deepchem/feat/dft_data.py
Outdated
@@ -161,7 +168,7 @@ def get_true_val(self) -> np.ndarray: | |||
return np.array(0) | |||
|
|||
@abstractmethod | |||
def get_val(self, qcs: List[KSCalc]) -> np.ndarray: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this back in?
deepchem/data/tests/test_dftyaml.py
Outdated
@@ -3,6 +3,7 @@ | |||
has_dqc = True | |||
except ModuleNotFoundError: | |||
has_dqc = False | |||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@advikavs Let's figure out the dqc doctest failure issue in a follow-up PR
Description
Adding spin and charge properties to dft data