Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Multitask regression task in HuggingFace models #3389

Merged
merged 3 commits into from
May 12, 2023

Conversation

arunppsg
Copy link
Contributor

Description

I have updated HuggingFaceModel class to allow for different type of tasks.

Earlier, task can only be finetuning or pretraining. If the task was pretraining, then the default
pretraining mode assumed is masked language modeling and data was prepared accordingly. The problem with this approach was other pretraining task like multitask regression uses different data batching process (the batching does not involve masking as required for mlm) and hence, there was no way to generate data for tasks like mtr.

The PR broadens the scope of task by including various types of task like mlm for masked language modeling, mtr for multitask regression, regression and classification for simple regression and classification tasks. Task of type finetuning is removed since finetuning itself involves multiple subtasks like regression, classification, mtr. Instead, users can directly specify the task.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

applies changes to test, docstrings
@arunppsg arunppsg changed the title dded support for Multitask regression task in HuggingFace models Added support for Multitask regression task in HuggingFace models May 10, 2023
@arunppsg arunppsg mentioned this pull request May 10, 2023
15 tasks
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but let's verify CI looks normal before merge

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit 19d501b into deepchem:master May 12, 2023
23 of 33 checks passed
@arunppsg arunppsg deleted the hf-models-mtr branch June 30, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants