Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsorted_segment_sum and unittest #3430

Merged
merged 5 commits into from Jun 19, 2023
Merged

Unsorted_segment_sum and unittest #3430

merged 5 commits into from Jun 19, 2023

Conversation

riya-singh28
Copy link
Contributor

@riya-singh28 riya-singh28 commented Jun 14, 2023 •
edited

Description

Adding unsorted_segment_sum function in pytorch_utils.py

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@riya-singh28 riya-singh28 changed the title add unsorted_segment_sum and unittest Unsorted_segment_sum and unittest Jun 14, 2023
@riya-singh28
Copy link
Contributor Author

@rbharath Ready for review.

rbharath
rbharath reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few comments below. Have also turned on the CI to run

deepchem/utils/pytorch_utils.py Outdated Show resolved Hide resolved
deepchem/utils/pytorch_utils.py Outdated Show resolved Hide resolved
deepchem/utils/test/test_pytorch_utils.py Show resolved Hide resolved
@riya-singh28
Copy link
Contributor Author

image

rbharath
rbharath reviewed Jun 16, 2023
View reviewed changes
deepchem/utils/pytorch_utils.py Outdated
# Shape of segment_ids should be equal to first dimension of data
assert segment_ids.shape[-1] == data.shape[0]

if len(segment_ids.shape) == 1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this if statement because of the earlier assert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@riya-singh28
Copy link
Contributor Author

@rbharath 21 tests are successful and 10 are failing. I have checked that the tests are not failing because of unsorted_segment_sum. Can you please re-review the PR?

rbharath
rbharath approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit d0761e6 into deepchem:master Jun 19, 2023
23 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbharath rbharath rbharath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riya-singh28 @rbharath